Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(shell-api): add convertShardKeyToHashed() MONGOSH-1050 #1364

Merged
merged 3 commits into from
Nov 30, 2022
Merged

feat(shell-api): add convertShardKeyToHashed() MONGOSH-1050 #1364

merged 3 commits into from
Nov 30, 2022

Conversation

addaleax
Copy link
Contributor

No description provided.

@addaleax addaleax marked this pull request as ready for review November 29, 2022 14:30
gribnoysup
gribnoysup approved these changes Nov 30, 2022
View reviewed changes
Copy link
Contributor

@gribnoysup gribnoysup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the tests are failing due to missing translations, but otherwise looks good to me

@addaleax addaleax merged commit 229c9a3 into main Nov 30, 2022
@addaleax addaleax deleted the 1050-dev branch November 30, 2022 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gribnoysup gribnoysup gribnoysup approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@addaleax @gribnoysup